Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(readme): remove alpha label #17

Merged
merged 1 commit into from
Jul 27, 2018
Merged

docs(readme): remove alpha label #17

merged 1 commit into from
Jul 27, 2018

Conversation

itsachen
Copy link
Contributor

What

  • Removes alpha label from README

Why

Library is at 1.0.0, docs are up on lob.com/docs

@itsachen itsachen requested a review from a team July 27, 2018 18:08
sjl2
sjl2 approved these changes Jul 27, 2018
View reviewed changes
Copy link

@sjl2 sjl2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itsachen itsachen merged commit 36c172a into master Jul 27, 2018
@itsachen itsachen deleted the remove-alpha branch July 27, 2018 18:12
@coveralls
Copy link

Pull Request Test Coverage Report for Build 255

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.323%
Totals Coverage Status
Change from base Build 228: 0.0%
Covered Lines: 28
Relevant Lines: 31
💛 - Coveralls

2 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 255

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.323%
Totals Coverage Status
Change from base Build 228: 0.0%
Covered Lines: 28
Relevant Lines: 31
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 255

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.323%
Totals Coverage Status
Change from base Build 228: 0.0%
Covered Lines: 28
Relevant Lines: 31
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmlittle dmlittle dmlittle approved these changes

@sjl2 sjl2 sjl2 approved these changes

Assignees

@itsachen itsachen

Labels
Trivial
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@itsachen @coveralls @dmlittle @sjl2