Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: creativesApi + spec tests #315

Merged
merged 7 commits into from
Jan 9, 2023
Merged

feat: creativesApi + spec tests #315

merged 7 commits into from
Jan 9, 2023

Conversation

jho44
Copy link
Contributor

@jho44 jho44 commented Jan 7, 2023

ticket

Added CreativesAPI and relevant integration tests

Related SDK Generator PR

Note: tests are failing because...it looks like Campaigns API is down for all of Lob?

@jho44 jho44 requested review from a team and BennyKitchell as code owners January 7, 2023 13:03
@BennyKitchell BennyKitchell changed the title feat: creativesApi + spec tests feat: creativesApi + spec tests Jan 9, 2023
@BennyKitchell BennyKitchell reopened this Jan 9, 2023
@BennyKitchell BennyKitchell changed the title feat: creativesApi + spec tests feat: creativesApi + spec tests Jan 9, 2023
@BennyKitchell BennyKitchell changed the title feat: creativesApi + spec tests feat: creativesApi + spec tests Jan 9, 2023
@BennyKitchell BennyKitchell changed the title feat: creativesApi + spec tests feat: creativesApi + spec tests Jan 9, 2023
@BennyKitchell BennyKitchell changed the title feat: creativesApi + spec tests feat: creativesApi + spec tests Jan 9, 2023
@BennyKitchell BennyKitchell merged commit c3164f7 into main Jan 9, 2023
@BennyKitchell BennyKitchell deleted the addCreatives branch January 9, 2023 21:34
BennyKitchell added a commit that referenced this pull request Jan 9, 2023
* feat: creativesApi + spec tests

* chore: merge main

* chore: merge main

* fix: run tests with e flag

* chore: merge main

* chore: merge main

Co-authored-by: BennyKitchell <bennykitchell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants