Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for coveralls API for GH actions #202

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

ShariqT
Copy link
Contributor

@ShariqT ShariqT commented Dec 16, 2021

This makes sure that the lcov.info file is generated by the "rake test" command and sent to coveralls.

@ShariqT ShariqT force-pushed the fixes-for-gh-test-coveralls-action branch from be19b69 to c8d4001 Compare December 16, 2021 03:23
@ShariqT ShariqT requested a review from mwj8410 December 16, 2021 03:24
@ShariqT
Copy link
Contributor Author

ShariqT commented Dec 16, 2021

Also added a fix for the resource_base.rb that fixes the undefined method error.

This makes sure that the lcov.info file is generated by the "rake test" command and sent to coveralls. Changed the "body" key in "client_params" to "payload".
@ShariqT ShariqT force-pushed the fixes-for-gh-test-coveralls-action branch from 6fc28e5 to 856cc05 Compare December 16, 2021 03:57
@ShariqT ShariqT merged commit ce7e2da into master Dec 16, 2021
@ShariqT ShariqT deleted the fixes-for-gh-test-coveralls-action branch December 16, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants