feat(base): create hello world with C++ bindings #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| @@ -0,0 +1 @@ | |||
| 6 | |||
There was a problem hiding this comment.
Should we match API's node version for now?
There was a problem hiding this comment.
I'm testing against several node versions, which is why the test code isn't ES6, but I thought it would be better to make it use the latest version supported. I can change it to 5 but since I'm testing against 6 also, I didn't think it made much sense.
robinjoseph08
force-pushed
the
hello-world
branch
from
70ab5e7
to
2f4fcf5
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Creates a Hello World Node.js Addon using C++ code that gets compiled into a requirable Node package.
Why
To lay the base to begin hooking into Poppler's
pdffonts.Notes
node-gyp(which comes with every installation of Node) to build/compile the C++ code.nanso that it can be targeted for many different versions of Node with one consistent API, even though v8's API have changed drastically.build/Release,build/Debug,build/default,build/Release/bindings, etc.). So instead of having a bunch oftry/catchs orfs.existss,bindingstakes care of that.