fix signature bugs #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adiazulay Ran into this issue today. Lobe is very user friendly and welcoming, but upon exporting I hit a brick wall of errors related to this issue. I stepped through and found the culprit, then saw that you had already applied a fix and initiated a PR. In anycase, after manually applying the changes in your merge request all works as expected. I would suggest adding an issue related to this to the issue page so other users will see it is a known issue |
Closed
|
Thanks for trying out the fix! I'll be merging this par later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a couple of bugs caused by the names of tensors being changed from the version this was developed on.
There was also a bug in the loading from signature for tensor flow since it was expecting a string for the model path not an ospath