-
-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix: create first-time user #2977
Conversation
@phuctm97 is attempting to deploy a commit to the LobeHub Pro Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for raising your pull request and contributing to our Community |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2977 +/- ##
==========================================
- Coverage 93.30% 93.29% -0.01%
==========================================
Files 383 383
Lines 23931 23937 +6
Branches 1747 1868 +121
==========================================
+ Hits 22328 22333 +5
- Misses 1603 1604 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks for you contribution~
❤️ Great PR @phuctm97 ❤️ The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world. |
### [Version 1.1.4](v1.1.3...v1.1.4) <sup>Released on **2024-06-22**</sup> #### 🐛 Bug Fixes - **misc**: Create first-time user on server db. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **misc**: Create first-time user on server db, closes [#2977](#2977) ([6f53f35](6f53f35)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>
🎉 This PR is included in version 1.1.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
### [Version 1.44.2](v1.44.1...v1.44.2) <sup>Released on **2024-06-22**</sup> #### 🐛 Bug Fixes - **misc**: Create first-time user on server db. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **misc**: Create first-time user on server db, closes [lobehub#2977](https://github.com/bentwnghk/lobe-chat/issues/2977) ([6f53f35](6f53f35)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>
This reverts commit 6f53f35.
### [Version 1.1.4](lobehub/lobe-chat@v1.1.3...v1.1.4) <sup>Released on **2024-06-22**</sup> #### 🐛 Bug Fixes - **misc**: Create first-time user on server db. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **misc**: Create first-time user on server db, closes [lobehub#2977](lobehub#2977) ([6f53f35](lobehub@6f53f35)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>
### [Version 1.1.4](lobehub/lobe-chat@v1.1.3...v1.1.4) <sup>Released on **2024-06-22**</sup> #### 🐛 Bug Fixes - **misc**: Create first-time user on server db. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **misc**: Create first-time user on server db, closes [lobehub#2977](lobehub#2977) ([6f53f35](lobehub@6f53f35)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>
💻 变更类型 | Change Type
🔀 变更说明 | Description of Change
For first-time user, automatically create a user in database. This handles issue where if Clerk webhook unexpected failed, the user won't be able to use the app at all.
📝 补充信息 | Additional Information
The code is optimized so that creating user only ever runs once per user and only if Clerk webhook failed and the code path is the same for all existing users.