Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix: -check_updates cannot be set by FEATURE_FLAGS #3038

Merged
merged 5 commits into from
Jun 27, 2024
Merged

🐛 fix: -check_updates cannot be set by FEATURE_FLAGS #3038

merged 5 commits into from
Jun 27, 2024

Conversation

hezhijie0327
Copy link
Contributor

@hezhijie0327 hezhijie0327 commented Jun 25, 2024

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • ⚡️ perf
  • 📝 docs

🔀 变更说明 | Description of Change

修复 "-check_updates" 设置无效的问题,在现有主线代码中忽略环境变量并强制检查更新

const Version = memo<{ mobile?: boolean }>(({ mobile }) => {
const [hasNewVersion, latestVersion, useCheckLatestVersion] = useGlobalStore((s) => [
s.hasNewVersion,
s.latestVersion,
s.useCheckLatestVersion,
]);
const { t } = useTranslation('common');
const { styles, theme } = useStyles();
useCheckLatestVersion();

📝 补充信息 | Additional Information

Copy link

vercel bot commented Jun 25, 2024

@hezhijie0327 is attempting to deploy a commit to the LobeHub Pro Team on Vercel.

A member of the Team first needs to authorize it.

@lobehubbot
Copy link
Member

👍 @hezhijie0327

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

@hezhijie0327
Copy link
Contributor Author

引入自 #2976

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Introduced from #2976

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.43%. Comparing base (8e54ca0) to head (c22790b).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3038      +/-   ##
==========================================
+ Coverage   93.41%   93.43%   +0.01%     
==========================================
  Files         381      382       +1     
  Lines       23525    23626     +101     
  Branches     1699     1816     +117     
==========================================
+ Hits        21977    22074      +97     
- Misses       1548     1552       +4     
Flag Coverage Δ
app 93.43% <ø> (+0.01%) ⬆️
server 68.05% <ø> (-0.69%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

vercel bot commented Jun 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lobe-chat-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2024 6:47am

@arvinxx arvinxx merged commit bdadfee into lobehub:main Jun 27, 2024
3 of 6 checks passed
@lobehubbot
Copy link
Member

❤️ Great PR @hezhijie0327 ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献,感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣,请加入我们的 discord,然后私信 @arvinxx@canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发,分享和讨论全球范围内的 AI 消息。

github-actions bot pushed a commit that referenced this pull request Jun 27, 2024
### [Version&nbsp;1.1.13](v1.1.12...v1.1.13)
<sup>Released on **2024-06-27**</sup>

#### 🐛 Bug Fixes

- **misc**: -check_updates cannot be set by FEATURE_FLAGS.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: -check_updates cannot be set by FEATURE_FLAGS, closes [#3038](#3038) ([bdadfee](bdadfee))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 1.1.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Jun 27, 2024
### [Version&nbsp;1.44.8](v1.44.7...v1.44.8)
<sup>Released on **2024-06-27**</sup>

#### 🐛 Bug Fixes

- **misc**: -check_updates cannot be set by FEATURE_FLAGS.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: -check_updates cannot be set by FEATURE_FLAGS, closes [lobehub#3038](https://github.com/bentwnghk/lobe-chat/issues/3038) ([bdadfee](bdadfee))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Mingholy pushed a commit to Mingholy/lobe-chat that referenced this pull request Jul 1, 2024
Mingholy pushed a commit to Mingholy/lobe-chat that referenced this pull request Jul 1, 2024
### [Version&nbsp;1.1.13](lobehub/lobe-chat@v1.1.12...v1.1.13)
<sup>Released on **2024-06-27**</sup>

#### 🐛 Bug Fixes

- **misc**: -check_updates cannot be set by FEATURE_FLAGS.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: -check_updates cannot be set by FEATURE_FLAGS, closes [lobehub#3038](lobehub#3038) ([bdadfee](lobehub@bdadfee))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
ipoly pushed a commit to ipoly/lobe-chat that referenced this pull request Jul 29, 2024
ipoly pushed a commit to ipoly/lobe-chat that referenced this pull request Jul 29, 2024
### [Version&nbsp;1.1.13](lobehub/lobe-chat@v1.1.12...v1.1.13)
<sup>Released on **2024-06-27**</sup>

#### 🐛 Bug Fixes

- **misc**: -check_updates cannot be set by FEATURE_FLAGS.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: -check_updates cannot be set by FEATURE_FLAGS, closes [lobehub#3038](lobehub#3038) ([bdadfee](lobehub@bdadfee))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants