🐛 fix: Disable clerk signup when env set #3126

vegetablesB · 2024-07-02T14:50:09Z

💻 变更类型 | Change Type

🔀 变更说明 | Description of Change

Update middle ware and page to redirect, update layout to disable the footer

环境变量是 NEXT_PUBLIC_DISABLE_CLERK_SIGN_UP

📝 补充信息 | Additional Information

相关issue:

vercel · 2024-07-02T14:50:18Z

@vegetablesB is attempting to deploy a commit to the LobeHub Pro Team on Vercel.

A member of the Team first needs to authorize it.

lobehubbot · 2024-07-02T14:50:21Z

👍 @vegetablesB

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献，请确保您已经遵循了我们的贡献指南，我们会尽快审查它。
如果您遇到任何问题，请随时与我们联系。

arvinxx · 2024-07-02T15:21:52Z

我建议使用 Feature Flag 而不是环境变量： https://lobehub.com/zh/docs/self-hosting/advanced/feature-flags

禁用的话，配置 -clerk_sign_up

vegetablesB · 2024-07-02T20:42:39Z

我建议使用 Feature Flag 而不是环境变量： https://lobehub.com/zh/docs/self-hosting/advanced/feature-flags

禁用的话，配置 -clerk_sign_up

修改了feature flag,请再review一下.

现在使用的是-clerk_sign_up来禁用clerk 的注册.

注册footer消失
如果访问/signup 也会转到login.

但是无法禁用使用accounts.xxx.com的注册页面.

src/layout/AuthProvider/Clerk/index.tsx

src/config/auth.ts

arvinxx

另外 SSO 登录暂时禁止不了对吧？

src/layout/AuthProvider/Clerk/index.tsx

vegetablesB · 2024-07-03T18:03:24Z

另外 SSO 登录暂时禁止不了对吧？

是的SSO登陆注册禁止不了,也只能在clerk关掉sso了.
试了一下,在login时登陆没有注册的google 账户, 会转到accounts.xxx.com/user, 然后退回来就可以看到登陆成功了.

目前只是footer 不显示, 和/signup 会转到/login. 用户还是可以使用accounts.xxx.com 来注册.

lobehubbot · 2024-07-03T18:03:35Z

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

In addition, SSO login cannot be disabled temporarily, right?

Yes, SSO login and registration cannot be disabled, and SSO can only be turned off at clerk.
I tried it. When logging in to an unregistered Google account, it will go to accounts.xxx.com/user, and then return to see that the login is successful.

Currently, only the footer is not displayed, and /signup will be redirected to /login. Users can still use accounts.xxx.com to register.

codecov · 2024-07-04T02:33:59Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.96%. Comparing base (6c4c8f7) to head (b88fb6c).
Report is 8 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff            @@
##             main    #3126    +/-   ##
========================================
  Coverage   93.96%   93.96%            
========================================
  Files         388      388            
  Lines       24149    24155     +6     
  Branches     1793     2756   +963     
========================================
+ Hits        22692    22698     +6     
  Misses       1457     1457

Flag	Coverage Δ
app	`93.96% <100.00%> (+<0.01%)`	⬆️
server	`68.20% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

arvinxx · 2024-07-04T02:59:36Z

修下测试

lobehubbot · 2024-07-04T02:59:46Z

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Fix the test

vercel · 2024-07-07T02:22:56Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
lobe-chat-database	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 7, 2024 2:42am

lobehubbot · 2024-07-07T02:23:06Z

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
lobe-chat-database	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Jul 7, 2024 2:22am

arvinxx

LGTM now, thanks for your contribution!

lobehubbot · 2024-07-07T02:53:20Z

❤️ Great PR @vegetablesB ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献，感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣，请加入我们的 discord，然后私信 @arvinxx 或 @canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发，分享和讨论全球范围内的 AI 消息。

### [Version 1.2.12](v1.2.11...v1.2.12) <sup>Released on **2024-07-07**</sup> #### 🐛 Bug Fixes - **misc**: Fixed mobile web page navigation issue with inbox assistant, support to disable clerk signup with feature flag. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **misc**: Fixed mobile web page navigation issue with inbox assistant, closes [#2693](#2693) ([4476a5e](4476a5e)) * **misc**: Support to disable clerk signup with feature flag, closes [#3126](#3126) ([4ead315](4ead315)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>

lobehubbot · 2024-07-07T02:58:57Z

🎉 This PR is included in version 1.2.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

### [Version 1.45.8](v1.45.7...v1.45.8) <sup>Released on **2024-07-07**</sup> #### 🐛 Bug Fixes - **misc**: Fixed mobile web page navigation issue with inbox assistant, support to disable clerk signup with feature flag. #### 💄 Styles - **misc**: Update deepseek max token. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **misc**: Fixed mobile web page navigation issue with inbox assistant, closes [lobehub#2693](https://github.com/bentwnghk/lobe-chat/issues/2693) ([4476a5e](4476a5e)) * **misc**: Support to disable clerk signup with feature flag, closes [lobehub#3126](https://github.com/bentwnghk/lobe-chat/issues/3126) ([4ead315](4ead315)) #### Styles * **misc**: Update deepseek max token, closes [lobehub#3143](https://github.com/bentwnghk/lobe-chat/issues/3143) ([4a241b9](4a241b9)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>

* feat: Disable signup when env set * feat: Disable Clerk sign-up based on feature flag * fix: change to client * fix: remove the logic for signup in middleware * chore: revert the space deletion * fix: update the url for login and signup * fix: fix footerAction update logic * test: update test for enableClerkSignUp

### [Version 1.2.12](lobehub/lobe-chat@v1.2.11...v1.2.12) <sup>Released on **2024-07-07**</sup> #### 🐛 Bug Fixes - **misc**: Fixed mobile web page navigation issue with inbox assistant, support to disable clerk signup with feature flag. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **misc**: Fixed mobile web page navigation issue with inbox assistant, closes [lobehub#2693](lobehub#2693) ([4476a5e](lobehub@4476a5e)) * **misc**: Support to disable clerk signup with feature flag, closes [lobehub#3126](lobehub#3126) ([4ead315](lobehub@4ead315)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>

* feat: Disable signup when env set * feat: Disable Clerk sign-up based on feature flag * fix: change to client * fix: remove the logic for signup in middleware * chore: revert the space deletion * fix: update the url for login and signup * fix: fix footerAction update logic * test: update test for enableClerkSignUp

### [Version 1.2.12](lobehub/lobe-chat@v1.2.11...v1.2.12) <sup>Released on **2024-07-07**</sup> #### 🐛 Bug Fixes - **misc**: Fixed mobile web page navigation issue with inbox assistant, support to disable clerk signup with feature flag. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **misc**: Fixed mobile web page navigation issue with inbox assistant, closes [lobehub#2693](lobehub#2693) ([4476a5e](lobehub@4476a5e)) * **misc**: Support to disable clerk signup with feature flag, closes [lobehub#3126](lobehub#3126) ([4ead315](lobehub@4ead315)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>

feat: Disable signup when env set

949e584

feat: Disable Clerk sign-up based on feature flag

1668326

vegetablesB force-pushed the disable-clerk-signup branch from bc8d67e to 1668326 Compare July 2, 2024 19:27

vegetablesB added 2 commits July 2, 2024 15:35

fix: change to client

ee548de

fix: remove the logic for signup in middleware

2689a92

arvinxx reviewed Jul 3, 2024

View reviewed changes

src/layout/AuthProvider/Clerk/index.tsx Outdated Show resolved Hide resolved

src/config/auth.ts Outdated Show resolved Hide resolved

vegetablesB added 2 commits July 2, 2024 21:35

chore: revert the space deletion

0dcf349

fix: update the url for login and signup

1207125

arvinxx reviewed Jul 3, 2024

View reviewed changes

src/layout/AuthProvider/Clerk/index.tsx Outdated Show resolved Hide resolved

arvinxx changed the title ~~feat: Disable clerk signup when env set~~ 🐛 fix: Disable clerk signup when env set Jul 3, 2024

vegetablesB added 2 commits July 3, 2024 18:48

fix: fix footerAction update logic

d37b9e6

Merge remote-tracking branch 'upstream/main' into disable-clerk-signup

392c629

vegetablesB requested a review from arvinxx July 3, 2024 23:18

test: update test for enableClerkSignUp

b88fb6c

vercel bot deployed to Preview – lobe-chat-database July 7, 2024 02:42 View deployment

arvinxx approved these changes Jul 7, 2024

View reviewed changes

arvinxx merged commit 4ead315 into lobehub:main Jul 7, 2024
6 of 7 checks passed

lobehubbot added the released label Jul 7, 2024

vegetablesB deleted the disable-clerk-signup branch July 12, 2024 23:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 fix: Disable clerk signup when env set #3126

🐛 fix: Disable clerk signup when env set #3126

vegetablesB commented Jul 2, 2024 •

edited by arvinxx

Loading

vercel bot commented Jul 2, 2024

lobehubbot commented Jul 2, 2024

arvinxx commented Jul 2, 2024 •

edited

Loading

vegetablesB commented Jul 2, 2024

arvinxx left a comment

vegetablesB commented Jul 3, 2024

lobehubbot commented Jul 3, 2024

codecov bot commented Jul 4, 2024 •

edited

Loading

arvinxx commented Jul 4, 2024

lobehubbot commented Jul 4, 2024

vercel bot commented Jul 7, 2024 •

edited

Loading

lobehubbot commented Jul 7, 2024

arvinxx left a comment

lobehubbot commented Jul 7, 2024

lobehubbot commented Jul 7, 2024

🐛 fix: Disable clerk signup when env set #3126

🐛 fix: Disable clerk signup when env set #3126

Conversation

vegetablesB commented Jul 2, 2024 • edited by arvinxx Loading

💻 变更类型 | Change Type

🔀 变更说明 | Description of Change

📝 补充信息 | Additional Information

vercel bot commented Jul 2, 2024

lobehubbot commented Jul 2, 2024

arvinxx commented Jul 2, 2024 • edited Loading

vegetablesB commented Jul 2, 2024

arvinxx left a comment

Choose a reason for hiding this comment

vegetablesB commented Jul 3, 2024

lobehubbot commented Jul 3, 2024

codecov bot commented Jul 4, 2024 • edited Loading

Codecov Report

arvinxx commented Jul 4, 2024

lobehubbot commented Jul 4, 2024

vercel bot commented Jul 7, 2024 • edited Loading

lobehubbot commented Jul 7, 2024

arvinxx left a comment

Choose a reason for hiding this comment

lobehubbot commented Jul 7, 2024

lobehubbot commented Jul 7, 2024

vegetablesB commented Jul 2, 2024 •

edited by arvinxx

Loading

arvinxx commented Jul 2, 2024 •

edited

Loading

codecov bot commented Jul 4, 2024 •

edited

Loading

vercel bot commented Jul 7, 2024 •

edited

Loading