Customized formatters and ttl on keys #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redis client is initialized from kwargs if redis_client is not passed by caller.
|
Hmm - changing to |
I bumped pytest-cov version in trunk, fresh coverage will be installed as dependecy. |
redis_client now defaults to redis defaults, but still allows caller to pass a non-default redis client.
Update pr to proposed changes including new tests.
|
Getting closer, I'll go back to the redis_kwargs to maintain compatibility. |
redis_client now defaults to redis defaults, but still allows caller to pass a non-default redis client.
Make changes discussed in pr8.
|
Take a look, let me know if you want me to rebase without the merge. |
lobziik
added a commit
that referenced
this pull request
Nov 23, 2015
Customized formatters and ttl on keys
|
Merge is ok. |
|
Awesome - thanks for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.