Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to when tabs are shown #538

Closed
willguv opened this issue Apr 25, 2023 · 10 comments
Closed

Change to when tabs are shown #538

willguv opened this issue Apr 25, 2023 · 10 comments
Assignees
Labels

Comments

@willguv
Copy link
Member

willguv commented Apr 25, 2023

Following on from Andy's comment

For the details group / tabs, we changed the switch between then to 1138px, so narrow viewports use detail dropdowns between the sections instead of vertical tabs.

Let's consider the impact of this change

@finnlewis
Copy link
Member

finnlewis commented Jun 21, 2023

Note; this is configuration in the tab group. Setting up vertical tabs, allows you to set the breakpoint.

Image

@finnlewis
Copy link
Member

finnlewis commented Jun 21, 2023

Note: this would probably just be for new installs.

Tasks:

  • identify all vertical tab groups in the LocalGov Drupal distribution.
  • Update configuration for each to 1138px breakpoint
  • possibly update the README.md for each repo
  • create pull requests in each repo with recommended release notes.

@agile-simon
Copy link

@willguv
Copy link
Member Author

willguv commented Jan 24, 2024

@stephen-cox please review Simon's PRs - thanks

@willguv
Copy link
Member Author

willguv commented Feb 13, 2024

@stephen-cox have you reviewed/ finished these PRs? Thanks

@stephen-cox
Copy link
Member

Hi @willguv - these are all merged apart from localgovdrupal/localgov_services#235, which has test failures that we haven't got to the bottom of.

@alexjohntweedie
Copy link

alexjohntweedie commented Feb 13, 2024 via email

@markconroy
Copy link
Member

I've merged the latest 2.x into the PR at #235

All tests are passing now, and the PR is working. I'm going to mark it as approved.

===
Thanks to Big Blue Door for sponsoring my time to work on this.

@mccrodp
Copy link

mccrodp commented Sep 24, 2024

Hey @markconroy, what remains as an open action in this issue following your merge above? It wasn't clear to me if anything else is required or if this can be closed now. Thanks.

@markconroy
Copy link
Member

I think we can close this one if all the PRs are merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Not doing
Development

No branches or pull requests

7 participants