-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change to when tabs are shown #538
Comments
Note: this would probably just be for new installs. Tasks:
|
Pull requests Directories News Services Subsites |
@stephen-cox please review Simon's PRs - thanks |
@stephen-cox have you reviewed/ finished these PRs? Thanks |
Hi @willguv - these are all merged apart from localgovdrupal/localgov_services#235, which has test failures that we haven't got to the bottom of. |
Yes
…On Tue, Feb 13, 2024, 2:34 PM Stephen Cox ***@***.***> wrote:
Hi @willguv <https://github.com/willguv> - these are all merged apart
from localgovdrupal/localgov_services#235
<localgovdrupal/localgov_services#235>, which has
test failures that we haven't got to the bottom of.
—
Reply to this email directly, view it on GitHub
<#538 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMTROUWBEU3Q5NMXU3CMF23YTN2ZFAVCNFSM6AAAAAAXLMNAY6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBRGY2TAMJRHE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
I've merged the latest 2.x into the PR at #235 All tests are passing now, and the PR is working. I'm going to mark it as approved. === |
Hey @markconroy, what remains as an open action in this issue following your merge above? It wasn't clear to me if anything else is required or if this can be closed now. Thanks. |
I think we can close this one if all the PRs are merged. |
Following on from Andy's comment
Let's consider the impact of this change
The text was updated successfully, but these errors were encountered: