Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds better focus orders for services button/menu #586

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

markconroy
Copy link
Member

Closes #578

What does this change?

  • Adds a new function in header.js so that when you click tab after last item in services menu, the focus goes back to the Services toggle button
  • When you shift+tab back out of services menu, the services button does not collapse the menu any more
  • Changes the aria-label to be more succinct.

How to test

  • Checkout this branch
  • Clear you cache
  • Tab to services button in header, click it
  • Tab through services links ensure that when you tab after the last one it goes back to the services button
  • Tab into services menu, shift+tab back out of it, ensure that the services menu does not collapse when you get back to the services button
  • Turn on screenreader, check that the aria-label for services button is "Services: jump to services"

Thanks to Big Blue Door for sponsoring my time to work on this.

@finnlewis finnlewis self-requested a review August 20, 2024 11:30
@markconroy markconroy merged commit 64bdd0e into 1.x Aug 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Services menu button: focus order and announcements
2 participants