Skip to content

Commit

Permalink
Merge pull request #373 from localgovdrupal/fix/3.x/deprecation
Browse files Browse the repository at this point in the history
fix: dynamic property deprecation
  • Loading branch information
finnlewis authored May 7, 2024
2 parents 3d745a2 + f73eb73 commit 52dbbd5
Showing 1 changed file with 11 additions and 11 deletions.
22 changes: 11 additions & 11 deletions tests/src/Functional/FacetsTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ protected function setUp() :void {
'summary' => 'One of the greatest joys known to man is to take a flight into ignorance in search of knowledge.',
];

$this->channel_node = $this->createNode([
$this->channelNode = $this->createNode([
'title' => 'Directory channel',
'type' => 'localgov_directory',
'status' => NodeInterface::PUBLISHED,
Expand Down Expand Up @@ -167,7 +167,7 @@ public function testFacetsGroupFilters() {
'status' => NodeInterface::PUBLISHED,
'localgov_directory_channels' => [
[
'target_id' => $this->channel_node->id(),
'target_id' => $this->channelNode->id(),
],
],
'localgov_directory_facets_select' => [
Expand All @@ -183,7 +183,7 @@ public function testFacetsGroupFilters() {
'status' => NodeInterface::PUBLISHED,
'localgov_directory_channels' => [
[
'target_id' => $this->channel_node->id(),
'target_id' => $this->channelNode->id(),
],
],
'localgov_directory_facets_select' => [
Expand All @@ -199,7 +199,7 @@ public function testFacetsGroupFilters() {
'status' => NodeInterface::PUBLISHED,
'localgov_directory_channels' => [
[
'target_id' => $this->channel_node->id(),
'target_id' => $this->channelNode->id(),
],
],
'localgov_directory_facets_select' => [
Expand All @@ -218,7 +218,7 @@ public function testFacetsGroupFilters() {
'status' => NodeInterface::PUBLISHED,
'localgov_directory_channels' => [
[
'target_id' => $this->channel_node->id(),
'target_id' => $this->channelNode->id(),
],
],
'localgov_directory_facets_select' => [
Expand Down Expand Up @@ -249,7 +249,7 @@ public function testFacetsGroupFilters() {
$this->cronRun();

// Check facets and check the right entries are shown.
$directory_url = $this->channel_node->toUrl()->toString();
$directory_url = $this->channelNode->toUrl()->toString();
$this->drupalGet($directory_url);

// Initially all four should be avalible.
Expand Down Expand Up @@ -336,7 +336,7 @@ public function testFacetSearchShowsAccessibleFacet() {
'status' => NodeInterface::PUBLISHED,
'localgov_directory_channels' => [
[
'target_id' => $this->channel_node->id(),
'target_id' => $this->channelNode->id(),
],
],
'localgov_directory_facets_select' => [
Expand All @@ -358,7 +358,7 @@ public function testFacetSearchShowsAccessibleFacet() {
'status' => NodeInterface::PUBLISHED,
'localgov_directory_channels' => [
[
'target_id' => $this->channel_node->id(),
'target_id' => $this->channelNode->id(),
],
],
'localgov_directory_facets_select' => [
Expand All @@ -380,7 +380,7 @@ public function testFacetSearchShowsAccessibleFacet() {
'status' => NodeInterface::PUBLISHED,
'localgov_directory_channels' => [
[
'target_id' => $this->channel_node->id(),
'target_id' => $this->channelNode->id(),
],
],
'localgov_directory_facets_select' => [
Expand All @@ -399,7 +399,7 @@ public function testFacetSearchShowsAccessibleFacet() {
'status' => NodeInterface::PUBLISHED,
'localgov_directory_channels' => [
[
'target_id' => $this->channel_node->id(),
'target_id' => $this->channelNode->id(),
],
],
'localgov_directory_facets_select' => [
Expand All @@ -421,7 +421,7 @@ public function testFacetSearchShowsAccessibleFacet() {
$this->cronRun();

// Check facets and check the right entries are shown.
$directory_url = $this->channel_node->toUrl()->toString();
$directory_url = $this->channelNode->toUrl()->toString();
$this->drupalGet($directory_url);

// Click facet 1.
Expand Down

0 comments on commit 52dbbd5

Please sign in to comment.