Add search result highlight to search result highlight display #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybroomfield
force-pushed
the
fix/215-search-result-highlight-site-search
branch
from
1188303
to
b86a737
Compare
Fix #215 This is for sitewide search, not the directory search. Usual cavet about using search_api as dependency applies. (If not using search_api, the search result display will be blank)
andybroomfield
force-pushed
the
fix/215-search-result-highlight-site-search
branch
from
b86a737
to
1d21233
Compare
ekes
approved these changes
Aug 29, 2022
There was a problem hiding this comment.
Manually tested with localgovdrupal/localgov_search#45 I'd say we want that in at the same time this is released.
|
@ekes would like us to add a test for this, following the example on https://github.com/localgovdrupal/localgov_step_by_step/pull/64/files#diff-afe33a5fb745c57e43f66de12ec75bfae6c2526c9e584f3e522a73eeb73800e6 |
finnlewis
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #215
This is for sitewide search, not the directory search.
Usual cavet about using search_api as dependency applies.
(If not using search_api, the search result display will be blank)