Configuration Helper get(Index|View) functions can return NULL. #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All calls to these methods already are actually checking if a value is returned. It makes sense that there are times there isn't a view or index (import for example). There are other checks later that it shoud operate on these indexes and views. Fixes #259
|
@chriswales95 this work for you? |
ekes
changed the title
ekes
changed the title
chriswales95
approved these changes
Jan 18, 2023
|
@ekes Looks good to me! I had the same solution, but was hesitant to suggest not knowing the code-base as well. Glad to give my stamp of approval. |
|
So. This is a class that doesn't have an interface, it's not likely to be called from code externally. But I does change the signature of the function that a public method of a class that's not marked as internal. Thoughts maybe from people using it @Adnan-cds @andybroomfield @budda This one should really be a minor version bump? |
finnlewis
approved these changes
Jan 18, 2023
|
These methods don't appear any use at BHCC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All calls to these methods already are actually checking if a value is returned. It makes sense that there are times there isn't a view or index (import for example). There are other checks later that it shoud operate on these indexes and views.
Fixes #259
Longer description #259 (comment)