Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(Proximity search): Facet display #273

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

Adnan-cds
Copy link
Contributor

@Adnan-cds Adnan-cds commented Mar 31, 2023

Facet preprocessing and template selection is broken in the proximity search views display of the Directory channel view. Fixed now.

How to reproduce

  1. Add one or more Facet types (e.g. "Location") to a Directory channel.
  2. Enable proximity search for that Directory channel.
  3. Add a few Directory venues to the above channel.
  4. Ensure these Directory venues are using the facet values from step 0.
  5. Open the Directory channel page and look at the facet block on the sidebar.
  6. While the facet values are present as a flat list, the facet type labels (e.g. "Location") are absent. This is because the facet preprocessor has no knowledge of the facet used in proximity search.

Screenshots

Facet preprocessing and template selection is broken in the proximity search
views display of the directory channel view.  Fixed now.
@Adnan-cds Adnan-cds marked this pull request as ready for review April 2, 2023 10:32
@Adnan-cds Adnan-cds requested review from ekes and finnlewis April 2, 2023 10:32
Copy link
Member

@ekes ekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right so this is just adding the display that proximity added to the custom facets. Makes sense. Because facets generates new versions for each display.

@finnlewis finnlewis merged commit 63301b1 into 2.x Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants