Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dynamic property deprecation #373

Merged
merged 1 commit into from
May 7, 2024
Merged

fix: dynamic property deprecation #373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions tests/src/Functional/FacetsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ protected function setUp() :void {
'summary' => 'One of the greatest joys known to man is to take a flight into ignorance in search of knowledge.',
];

$this->channel_node = $this->createNode([
$this->channelNode = $this->createNode([
'title' => 'Directory channel',
'type' => 'localgov_directory',
'status' => NodeInterface::PUBLISHED,
Expand Down Expand Up @@ -167,7 +167,7 @@ public function testFacetsGroupFilters() {
'status' => NodeInterface::PUBLISHED,
'localgov_directory_channels' => [
[
'target_id' => $this->channel_node->id(),
'target_id' => $this->channelNode->id(),
],
],
'localgov_directory_facets_select' => [
Expand All @@ -183,7 +183,7 @@ public function testFacetsGroupFilters() {
'status' => NodeInterface::PUBLISHED,
'localgov_directory_channels' => [
[
'target_id' => $this->channel_node->id(),
'target_id' => $this->channelNode->id(),
],
],
'localgov_directory_facets_select' => [
Expand All @@ -199,7 +199,7 @@ public function testFacetsGroupFilters() {
'status' => NodeInterface::PUBLISHED,
'localgov_directory_channels' => [
[
'target_id' => $this->channel_node->id(),
'target_id' => $this->channelNode->id(),
],
],
'localgov_directory_facets_select' => [
Expand All @@ -218,7 +218,7 @@ public function testFacetsGroupFilters() {
'status' => NodeInterface::PUBLISHED,
'localgov_directory_channels' => [
[
'target_id' => $this->channel_node->id(),
'target_id' => $this->channelNode->id(),
],
],
'localgov_directory_facets_select' => [
Expand Down Expand Up @@ -249,7 +249,7 @@ public function testFacetsGroupFilters() {
$this->cronRun();

// Check facets and check the right entries are shown.
$directory_url = $this->channel_node->toUrl()->toString();
$directory_url = $this->channelNode->toUrl()->toString();
$this->drupalGet($directory_url);

// Initially all four should be avalible.
Expand Down Expand Up @@ -336,7 +336,7 @@ public function testFacetSearchShowsAccessibleFacet() {
'status' => NodeInterface::PUBLISHED,
'localgov_directory_channels' => [
[
'target_id' => $this->channel_node->id(),
'target_id' => $this->channelNode->id(),
],
],
'localgov_directory_facets_select' => [
Expand All @@ -358,7 +358,7 @@ public function testFacetSearchShowsAccessibleFacet() {
'status' => NodeInterface::PUBLISHED,
'localgov_directory_channels' => [
[
'target_id' => $this->channel_node->id(),
'target_id' => $this->channelNode->id(),
],
],
'localgov_directory_facets_select' => [
Expand All @@ -380,7 +380,7 @@ public function testFacetSearchShowsAccessibleFacet() {
'status' => NodeInterface::PUBLISHED,
'localgov_directory_channels' => [
[
'target_id' => $this->channel_node->id(),
'target_id' => $this->channelNode->id(),
],
],
'localgov_directory_facets_select' => [
Expand All @@ -399,7 +399,7 @@ public function testFacetSearchShowsAccessibleFacet() {
'status' => NodeInterface::PUBLISHED,
'localgov_directory_channels' => [
[
'target_id' => $this->channel_node->id(),
'target_id' => $this->channelNode->id(),
],
],
'localgov_directory_facets_select' => [
Expand All @@ -421,7 +421,7 @@ public function testFacetSearchShowsAccessibleFacet() {
$this->cronRun();

// Check facets and check the right entries are shown.
$directory_url = $this->channel_node->toUrl()->toString();
$directory_url = $this->channelNode->toUrl()->toString();
$this->drupalGet($directory_url);

// Click facet 1.
Expand Down
Loading