Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory facets label #46

Closed
wants to merge 6 commits into from
Closed

Conversation

Adnan-cds
Copy link
Contributor

Fix for minor typo.

Fix for minor typo.
Trying to install composer v1 over the default composer v2 using the shivammathur/setup-php Action.
@Adnan-cds
Copy link
Contributor Author

I had to add the shivammathur/setup-php@v2 action to the Github actions test workflow file to get past the chaos caused by composer v2. Happy to drop it if you want to.

@stephen-cox
Copy link
Member

Happy with the typo fix, but not sure about committing the update to the Github CI stuff until we have decided on a definite solution to the problem. I have added some comments on the issue here about the CI issues: localgovdrupal/localgov#152 (comment)

The build container now carries composer v1, so we no longer need the shivammathur/setup-php@v2 action.
Move down the "composer create-project" step.  It depends on the docker-compose step.
This step depends on the newly relocated "composer create-project" step.
@Adnan-cds
Copy link
Contributor Author

Hi Steve,
I have just tried to replace the shivammathur/setup-php@v2 action with changes similar to the composer pinning task. Unfortunately the "actions/checkout@v2" action is having file permission issues. I am wondering what I have missed. Could you please take a look when you have some time.

FAO @stephen-cox

@Adnan-cds
Copy link
Contributor Author

This one has been superseded by #48

@Adnan-cds Adnan-cds closed this Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants