Prevent localgov_election_candidate paragraphs from generating new re… #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finnlewis
requested review from
chriswales95,
stephen-cox,
markconroy and
dedavidson
|
@finnlewis Just going to review now. If this is a permanent fix, I'd like to see 49a75fa reverted as part of this. |
|
@chriswales95 good call! I think we update the README to explain that revisions does not currently work. I'll look now. |
|
@finnlewis Okay, I tested and yes I no longer get the funny graphs but yeah the paragraph revisions don't work. So you can change a vote, revert the area vote revision, and the vote amount is still the old value. Much better than before @finnlewis! Any ideas on how we'd fully support revisions? |
chriswales95
approved these changes
Jul 4, 2024
|
This PR is working for me to stop the funny chart. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…visions.
See #94
Please test this!
Steps to reproduce the original bug:
#94 (comment)
With this small change, localgov_election_candidate paragraphs should not generate new revisions, so the duplicate revision creation is averted.
This mitigates the bug and prevents random data displaying, but still means revisions does not work.