Fix: Results heading on the Summary page #59
Conversation
Varies the results heading depending on the type of the election.
Declaring the Entity type manager using constructor property.
|
Hi Adnan, thanks for making this change. Is it possible to use other words here? We could use "Constituency results" for example Not sure on wording for other election types but we could review Please let me know what you think |
Hi Will, these wordings are coming from the "Type of election" dropdown of the Election type nodes: These wordings are defined in a config file bundled with this module. So yes, we should be able to modify these wordings if necessary. |
|
The type of election in this case is National Parliamentary, but the division is a constituency. Is it possible to leave the type name as it is and change the 'ward results' wording? |
Also, for National parliament type elections, use the term "Constituency results" instead of "National parliamentary results".
Done. |
Election type name rendering for non-constituency elections were broken. Fixed now.
There was a problem hiding this comment.
Hi @Adnan-cds, makes sense to me. Two things:
- is there an issue for this or something in a project somewhere?
- Do you think we might need a test for this?
Tests dynamic results heading text on the Election summary page.
|
Varies the results heading depending on the type of the election.
How to reproduce:
This change fixes the wording of the heading to say National Parliamentary results, Parish results and so on.
Resolves #72