-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes date field validation message presents in reverse order #72
Conversation
…ithub.com/localgovdrupal/localgov_forms into feature/error-messasge-date-display-order
Just discussing in Merge Tuesday with @MattOz-CDS @Adnan-cds @ekes Thinking it would be safer to namespace the date format to something like:
This would keep it namespaced and reduce the chances of conflicts with existing date formats. |
Is So maybe not calling it html date as thats for the spec. |
Alright Andy, thanks for sharing your thoughts on this. The name choice was inspired by the names of other date formats that are present in our Drupal install. I assumed that this was an established naming convention, so that's why I went with it. I'm happy to change it, that's no problem. What would you recommend? I also agree that it should be configurable for site builders. I'm happy to do that as well, its just that I was looking for a quick win because this change is urgently needed. |
I don't know, it was a question! :-) |
Overrides the validateDate method in the Datebase class so that date validation error messages display a UK style date format e.g dd-mm-yyyy.
https://github.com/localgovdrupal/localgov_forms/issues/67