Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release pull request for 1.0.0-apha3 #15

Merged
merged 5 commits into from
Dec 9, 2020
Merged

New release pull request for 1.0.0-apha3 #15

merged 5 commits into from
Dec 9, 2020

Conversation

finnlewis
Copy link
Member

No description provided.

Adnan-cds and others added 5 commits November 10, 2020 16:02
Replaces calls to deprecated set-env
Drupal was reporting the template suggestions perfectly fine in the twig debug output but not actually picking them up. This is because everything has to be underscores in the suggestions, which then get converted to dashes.
Add template suggestions for bundle and view mode
@finnlewis
Copy link
Member Author

We'd like to tag this today if we can @Adnan-cds and @andybroomfield - but checking with you guys first just to flag as I know Croydon is about to go live, so don't want to ruffle any feathers!

Copy link
Contributor

@Adnan-cds Adnan-cds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@Adnan-cds
Copy link
Contributor

Adnan-cds commented Dec 9, 2020

Hi Finn,
I have already tested this change in the LocalGov Croydon site and it worked fine yesterday. So feel free to release today.

@finnlewis finnlewis merged commit 9d960a8 into release Dec 9, 2020
@finnlewis
Copy link
Member Author

Thanks @Adnan-cds ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants