Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Lando to use the Drupal9 recipe and PHP 8.1. #66

Merged
merged 12 commits into from
Apr 25, 2022
Merged

Update Lando to use the Drupal9 recipe and PHP 8.1. #66

merged 12 commits into from
Apr 25, 2022

Conversation

finnlewis
Copy link
Member

No description provided.

@finnlewis finnlewis mentioned this pull request Apr 4, 2022
Closed
@finnlewis
Copy link
Member Author

I'm interested in people's thoughts on this.

It seems sensible to be testing against PHP 7.4 and 8.1 for now, which is what Thunder are doing, and to fix any tests that fail in their respective projects.

I think the PHP 8.1 coding standards tests are failing as the build is still pulling through PHP 7.4 from the main branch.

The PHPUnit tests will need looking at.

Any thoughts or suggestions on how to improve this?

@Adnan-cds
Copy link
Contributor

Any thoughts or suggestions on how to improve this?

Hi Finn, I see only one error which is about the localgov_openreferral module. It looks as if the HTTP response for an unpublished organization type record is missing the "Content-Type" header which is leading to all the errors. Needs more digging. @ekes is the best person to look into this IMHO.

@stephen-cox stephen-cox linked an issue Apr 11, 2022 that may be closed by this pull request
PHP 8.1 and Drupal 9 Lando recipe #65
Closed
stephen-cox
stephen-cox approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@stephen-cox stephen-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests all pass. We got full support for PHP 8.1 🥳

Happy to approve

@finnlewis
Copy link
Member Author

Woop woop! Nice work @stephen-cox @ekes @markconroy @Adnan-cds @andybroomfield

@finnlewis finnlewis merged commit 3124cc8 into 2.x Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephen-cox stephen-cox stephen-cox approved these changes

@Adnan-cds Adnan-cds Awaiting requested review from Adnan-cds

@andybroomfield andybroomfield Awaiting requested review from andybroomfield

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP 8.1 and Drupal 9 Lando recipe
3 participants
@finnlewis @Adnan-cds @stephen-cox