Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto heading id filter to the wysiwyg format on install. #143

Merged
merged 7 commits into from
Feb 27, 2024

Conversation

rupertj
Copy link
Member

@rupertj rupertj commented Feb 6, 2024

Fix for #142

@rupertj
Copy link
Member Author

rupertj commented Feb 6, 2024

I've made an issue and a patch to add the functionality we need to auto_heading_ids here: https://www.drupal.org/project/auto_heading_ids/issues/3419508

@rupertj
Copy link
Member Author

rupertj commented Feb 13, 2024

I've copied in the patched version of the filter we're using from auto_heading_ids and removed it as a dependency. If they accept the patch, I'll consider taking our copy out and reverting back to using auto_heading_ids.

@finnlewis finnlewis self-assigned this Feb 27, 2024
@finnlewis
Copy link
Member

I'll test this!

Copy link
Member

@finnlewis finnlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works a treat, thanks @rupertj !

@rupertj
Copy link
Member Author

rupertj commented Feb 27, 2024

Excellent. Thanks @finnlewis!

@rupertj rupertj merged commit 8294884 into 1.x Feb 27, 2024
8 checks passed
@rupertj rupertj deleted the fix/1.x/142-add-auto-heading-ids-to-wysiwyg branch February 27, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants