Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added hook_modules_installed() to immediately delete the book node type when book module is installed. #146

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

rupertj
Copy link
Member

@rupertj rupertj commented Feb 20, 2024

…pe when book module is installed.

@rupertj
Copy link
Member Author

rupertj commented Feb 20, 2024

I'm testing this now:

  • Book page type isn't present if publications is enabled when book isn't.
  • Book page type is present if publications is enabled when book is.
  • Book page type isn't present if publications is enabled when book isn't, via config import.
  • Book page type is present if publications is enabled when book is, via config import.

@finnlewis
Copy link
Member

Thanks @rupertj !

@andybroomfield would you be able to test this? I know you use book module, so you're well placed to confirm this does not have any unintended consequences.

@joachim-n
Copy link
Contributor

joachim-n commented Feb 20, 2024

I don't understand why this is a different PR?

EDIT: NM, saw comment on slack.

@finnlewis
Copy link
Member

@andybroomfield might you be able to give this a quick test on your site?

Copy link
Member

@finnlewis finnlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and works for me.

If do nit already have book module installed, I don't get the book content type.

If I already have book module installed, the book content types sticks around.

Great!

I'd still love for @andybroomfield to test it on the BHCC site if possible.

Copy link
Contributor

@andybroomfield andybroomfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine from me, though we have a different content type not book.

@rupertj
Copy link
Member Author

rupertj commented Feb 28, 2024

Excellent. Thanks both!

@rupertj rupertj merged commit 0c7b6e4 into 1.x Feb 28, 2024
10 of 16 checks passed
@rupertj rupertj deleted the fix/1.x/140-prevent-book-node-type branch August 22, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants