Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1.x/42/toc block find all headings #44

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

rupertj
Copy link
Member

@rupertj rupertj commented Mar 22, 2023

This PR will:

  • Split out the part of the ToC block that finds headings in content into its own HeadingFinder service. This makes it easier for us to test, but also lets people substitute their own implementation if they want to.
  • Add an interface for HeadingFinder.
  • Make the HeadingFinder more flexible in the headings it can find, compared to the existing code.
  • Add unit test coverage for the HeadingFinder.

Fixes #42

@jbloomfield jbloomfield self-requested a review March 23, 2023 10:33
@finnlewis
Copy link
Member

Nice! I think merge this @rupertj - I was just flagging it to @j4-m for interest as much as anything

@rupertj
Copy link
Member Author

rupertj commented Mar 23, 2023

Cool. Will do. Thanks!

@rupertj rupertj merged commit 967e578 into 1.x Mar 23, 2023
@rupertj rupertj deleted the feature/1.x/42/toc-block-find-all-headings branch March 23, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ToC block won't find all headings
3 participants