52 - Page title block #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rupertj
requested changes
May 2, 2023
config/install/core.entity_view_display.node.localgov_publication_page.default.yml
Show resolved
Hide resolved
6 tasks
finnlewis
approved these changes
May 18, 2023
There was a problem hiding this comment.
This is working as a page title block, but might raise some new questions about whether to use the title of the parent landing page if extant, and whether to display the title of the child pages on each child page.
I think we merge this and test on an alpha release to see how it plays in real life scenarios.
|
And thanks @jbloomfield ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.