Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testcontainers docs #486

Merged
merged 12 commits into from
Feb 27, 2023
Merged

Testcontainers docs #486

merged 12 commits into from
Feb 27, 2023

Conversation

eddumelendez
Copy link
Contributor

@eddumelendez eddumelendez commented Feb 13, 2023

Add Testcontainers to Integrations section

@github-actions
Copy link

github-actions bot commented Feb 13, 2023

⚡️ Deploying PR Preview...

@eddumelendez eddumelendez changed the title testcontainers Testcontainers docs Feb 13, 2023
Copy link
Contributor

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added two tiny changes regarding the URL.

For the Go examples, how do you want me to contribute them? A PR against this branch? wait for the merge?

Comment on lines 37 to 38
### Testcontainers for .NET

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I submitted a PR restructuring the page layout to leverage tabs, as in https://docs.localstack.cloud/user-guide/integrations/copilot/ You probably want to take a look there: https://github.com/eddumelendez/localstack-docs/pull/1

@eddumelendez eddumelendez marked this pull request as ready for review February 20, 2023 19:05
@eddumelendez eddumelendez requested review from HarshCasper and removed request for tinyg210 February 22, 2023 19:33
@HarshCasper HarshCasper merged commit 8fe16bb into localstack:main Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants