Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Lambda runtime versions and increase sleep time #10698

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

joe4dev
Copy link
Member

@joe4dev joe4dev commented Apr 19, 2024

Motivation

The hotreloading test failed in CI, this PR makes it more reliable.

After merging #10591
We got this test failure: https://app.circleci.com/pipelines/github/localstack/localstack/24343/workflows/37c4c31a-3a5c-40d1-8f05-ee83f59d9209/jobs/201483/tests

Changes

  • Increase sleep time slightly
  • Bump Lambda runtimes (using the same as many other tests reduces the likelihood of an extra pull)

@joe4dev joe4dev added the semver: patch Non-breaking changes which can be included in patch releases label Apr 19, 2024
@joe4dev joe4dev self-assigned this Apr 19, 2024
@joe4dev joe4dev marked this pull request as ready for review April 19, 2024 16:27
Copy link

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 31m 32s ⏱️ +3s
2 890 tests ±0  2 606 ✅ ±0  284 💤 ±0  0 ❌ ±0 
2 892 runs  ±0  2 606 ✅ ±0  286 💤 ±0  0 ❌ ±0 

Results for commit 7eb7f01. ± Comparison against base commit 51b397f.

This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.
tests.aws.services.lambda_.test_lambda_developer_tools.TestHotReloading ‑ test_hot_reloading[nodejs18.x]
tests.aws.services.lambda_.test_lambda_developer_tools.TestHotReloading ‑ test_hot_reloading[python3.9]
tests.aws.services.lambda_.test_lambda_developer_tools.TestHotReloading ‑ test_hot_reloading[nodejs20.x]
tests.aws.services.lambda_.test_lambda_developer_tools.TestHotReloading ‑ test_hot_reloading[python3.12]

@joe4dev joe4dev added this to the 3.4 milestone Apr 22, 2024
Copy link
Member

@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@joe4dev joe4dev merged commit 536cc28 into master Apr 23, 2024
35 checks passed
@joe4dev joe4dev deleted the bump-lambda-runtimes branch April 23, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants