Add some docs for core classes #1641
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kirill Chernyshov <kc875@cornell.edu>
Bluefire2
force-pushed
the
some-database-docs
branch
from
8eb64c1
to
f66736b
Compare
rfecher
approved these changes
Dec 13, 2019
|
How could the coverage decrease (or change at all), if only docstrings are changed? Was there a concurrent PR that had been merged? |
|
Looks like the formatter needs to be run on the updated classes before the build will pass. |
|
Changed files can be formatted by running |
|
I have rolled the changes from this PR into #1669. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add javadocs for {Metadata, Row} x {Reader, Writer, Deleter}. We also removed
publicfrom interface methods since it's redundant (interface methods can't have any other access level in Java 8).