Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: constant time hash verification #149

Merged
merged 1 commit into from
Feb 20, 2022
Merged

Fix: constant time hash verification #149

merged 1 commit into from
Feb 20, 2022

Commits on Dec 19, 2021

  1. fix(crypto): use constant-time comparison for hash verification 

    All credit goes to @phlay for pointing this out.

Using regular comparison on the byte slice will abort as soon as the
first byte doesn't match. This could open up the system to timing
attacks on the verification.
Using `openssl::memcmp::eq`, the comparison runs in constant-time.
    @milgner
    milgner committed Dec 19, 2021
    Configuration menu
    Copy the full SHA
    cb4faec View commit details
    Browse the repository at this point in the history