docs: Fix dead links #369
Open
docs: Fix dead links #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AiyionPrime
force-pushed
the
ci/deadlinks
branch
5 times, most recently
from
31848b3
to
41cef1e
Compare
|
I disliked the idea of fetching |
AiyionPrime
force-pushed
the
ci/deadlinks
branch
from
41cef1e
to
13838d4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
AiyionPrime
force-pushed
the
ci/deadlinks
branch
from
13838d4
to
674a50e
Compare
AiyionPrime
force-pushed
the
ci/deadlinks
branch
2 times, most recently
from
ec24cd7
to
1815a8c
Compare
Use cargo-binstall to avoid building cargo-deadcode from source in CI.
AiyionPrime
force-pushed
the
ci/deadlinks
branch
from
1815a8c
to
82a6296
Compare
which would lead to internal dead links.
according to their documented functions signature.
while regular build warnings are ignored in this stage.
AiyionPrime
force-pushed
the
ci/deadlinks
branch
from
82a6296
to
d567110
Compare
|
Rebased onto master, dropped the workaround for the webclient example. |
|
@locka99 is there anything left to do here? |
|
@locka99 are there any objections from your side on this matter? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kwinz This intends to resolve #295.
@locka99 Everything but the broken web-client sample is documented properly, as its old actix version features structs not present in the more recent one documented for the main crate.
cargo docdoes not handle different major versions with breaking changes clever enough.This PR consists of atomic conventional commits (which could be cleanly rebased onto master), so the workaround (40ce6b6a75b6c79fb16be75a4f9e216cda2f8e92) can be reverted easily once #291 has been resolved.