Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ServiceFault toresponse_header #60

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

svanharmelen
Copy link
Contributor

In addition I sorted al the big lists to make it easier to find anything in them. Let me know if you want that part reverted…

The only logical change is on lines 222 and 267.

Fixes #59

@svanharmelen
Copy link
Contributor Author

FYI I understand that before the ordering was (more or less) following the logical order or how the protocol works, yet it was quite nasty to search for things in those big lists. If you don't like them being ordered alphabetically, please let me know so I can revert. No problem...

@locka99
Copy link
Owner

locka99 commented Sep 23, 2020

Hi, the supported_message.rs is generated from gen_supported_message.js script. I've changed the script to treat ServiceFault as a response, so can you see if the head fixes your issue?

@locka99
Copy link
Owner

locka99 commented Sep 23, 2020

I basically just changed gen_supported_message.js to create the source code that treats ServiceFault as a response

@svanharmelen
Copy link
Contributor Author

Ow man, how did I miss the header in that file:

image

I did notice that in other files, but somehow seemed to have missed it here 😏

I tested master, but it gave a panic: thread 'tokio-runtime-worker-1' panicked at 'explicit panic', /Users/svanharmelen/code/svanharmelen/opcua/core/src/supported_message.rs:274:18 It seems it needs to also be added to the response_header, so added that (the correct way by adding to the js file and running the node cmd...

@svanharmelen svanharmelen changed the title Add ServiceFault to is_response and response_header Add ServiceFault toresponse_header Sep 23, 2020
@locka99 locka99 merged commit 7e7b8ab into locka99:master Sep 24, 2020
@svanharmelen svanharmelen deleted the svh/f-service-fault-response branch September 24, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A response with request handle 0 doesn't belong to any request and will be ignored
2 participants