Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- fix for Panic with very large requested_session_timeout, Fixes #62 #63

Merged
merged 1 commit into from
Oct 10, 2020
Merged

- fix for Panic with very large requested_session_timeout, Fixes #62 #63

merged 1 commit into from
Oct 10, 2020

Conversation

szallol
Copy link
Contributor

@szallol szallol commented Oct 1, 2020

  • if the max session_timeout become std::u64::MAX and the multiplication overflow and panic. A solution is to first divide and then multiply

@szallol
- fix for Panic with very large requested_session_timeout, Fixes #62
8e987ac 
- if the max session_timeout become std::u64::MAX and the multiplication overflow and panic. A solution is to first divide and then multiply
@locka99 locka99 merged commit 9e8588e into locka99:master Oct 10, 2020
locka99 added a commit that referenced this pull request Nov 25, 2020
@nkbai @szallol
@svanharmelen @locka99
Tokio 0.2 (#77)
be3dabf 
* remove useless Sized

* remove useless Send and Sync implementations.
Send and Sync is automatically implemented when the compiler determines
it's appropriate.

* user can manage client_handle by himself.

* - fix for Panic with very large requested_session_timeout, Fixes #62 (#63)

- if the max session_timeout become std::u64::MAX and the multiplication overflow and panic. A solution is to first divide and then multiply

* upgrade dependency  tokio to version 0.2:
1. remove dependency tokio-compact
2. upgrade tokio to 0.2
3. upgrade futures to 0.3

* use  tokio  thread runtime.

* Make it possible to use custom named .pem certs (#66)

* remove shutdown because it's useless.
Connection will be closed after return of spawn_writing_loop_task.
if add await here, it will hold a MutexGuard across await, and it's a compiler error.

* refactor of spawn_writing_loop_task

* remove useless test code

* This part of the translation is not functionally equivalent

* use atomic to replace mutex for finish_flag

* impl Read for [MessageChunk] to avoid memory copy.

* sample modbus-server dependency upgrades to tokio 0.2

* is_abort mismatch

* Add some planned stuff for 0.9, change indentation

* 1. tokio_compat is back. rt.block_on not equals tokio_compat::run
2. add WaitGroup, but it's a little hard to use for complex tasks.
3. samples/modbus-server  upgrade to tokio 0.2
4. fix a bug for samples/modbus-server, nodeId conflict.

* Compliance - make sample methods respond properly when invalid arguments are supplied.

* Implement Aes256-Sha256-RsaPss

* demo-server startup error

* Refactor message processing in server in anticipation of async work in server

* UnboundedSender and Message are implementation details so wrap in a class

* Pass message sender into the message handler

* Try to properly handle session errors (#73)

I'll apply this, thanks!

* comment for core/wait_group

Co-authored-by: bai <nkbai@163.com>
Co-authored-by: Szallo Laszlo <szallol@gmail.com>
Co-authored-by: Sander van Harmelen <sander@vanharmelen.nl>
Co-authored-by: Adam Lock <locka99@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@locka99 locka99 locka99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szallol @locka99