Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ostream operators, MeshcatVisualizer fix, removal of ineffective SIMD reduction #932

Merged
merged 18 commits into from
Apr 26, 2021

Conversation

wxmerkt
Copy link
Collaborator

@wxmerkt wxmerkt commented Apr 23, 2021

This PR includes:

  1. operator<< for shooting problem, action model, and differential action model to enable print(ddp.problem) or print(ddp.running_models[t]) which is useful in debugging to get information on the problem
  2. Removes the ineffective OpenMP simd instructions previously pointed out by Justin and also notified by the clang compiler as not optimised
  3. Fixes the MeshcatVisualizer when using the latest Pinocchio devel branch (not sure when it broke)

@wxmerkt wxmerkt changed the title Topic/add print operators ostream operators, MeshcatVisualizer fix, removal of ineffective SIMD reduction Apr 23, 2021
Copy link
Member

@cmastalli cmastalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank your for this work. It is quite clean and nice! I just left a few comments, and the most important point is about 'auto' keyword.

Regarding the displayers, we should create unittests. Feel free to include them in this PR (or create an issue if you don't have bandwidth now) :)

include/crocoddyl/core/action-base.hxx Outdated Show resolved Hide resolved
include/crocoddyl/core/diff-action-base.hxx Outdated Show resolved Hide resolved
include/crocoddyl/core/integrator/euler.hxx Outdated Show resolved Hide resolved
include/crocoddyl/core/optctrl/shooting.hpp Outdated Show resolved Hide resolved
include/crocoddyl/core/optctrl/shooting.hxx Outdated Show resolved Hide resolved
Copy link
Member

@proyan proyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, Thanks Carlos for the review.

Regarding the CI failure, it seems to be an apt issue, perhaps the new packages aren't available fully. Could you please run again @wxmerkt ?

@wxmerkt
Copy link
Collaborator Author

wxmerkt commented Apr 25, 2021

I restarted Travis but robotpkg is still a bit in a weird sync state so it won't pass. As long as gepgitlab passed we should be good?

@proyan
Copy link
Member

proyan commented Apr 25, 2021

From my side it should be okay to merge. I'll let Carlos do the merging, since he provided the review

@proyan
Copy link
Member

proyan commented Apr 25, 2021

Thanks @wxmerkt for this nice work

@cmastalli
Copy link
Member

cmastalli commented Apr 26, 2021

@wxmerkt I have pushed a commit that fixes the code format (which includes c++98 compatibility). Note that the code format is hardly enforced in Travis and softly enforced in gitlab-ci. It is also needed to satisfy the 16.04 job (which it failed in gitlab-ci).

I will merge it after the current jobs finish (I will ignore Travis to avoid further delays).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants