-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ostream operators, MeshcatVisualizer fix, removal of ineffective SIMD reduction #932
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank your for this work. It is quite clean and nice! I just left a few comments, and the most important point is about 'auto' keyword.
Regarding the displayers, we should create unittests. Feel free to include them in this PR (or create an issue if you don't have bandwidth now) :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, Thanks Carlos for the review.
Regarding the CI failure, it seems to be an apt
issue, perhaps the new packages aren't available fully. Could you please run again @wxmerkt ?
I restarted Travis but robotpkg is still a bit in a weird sync state so it won't pass. As long as gepgitlab passed we should be good? |
From my side it should be okay to merge. I'll let Carlos do the merging, since he provided the review |
Thanks @wxmerkt for this nice work |
@wxmerkt I have pushed a commit that fixes the code format (which includes c++98 compatibility). Note that the code format is hardly enforced in Travis and softly enforced in gitlab-ci. It is also needed to satisfy the 16.04 job (which it failed in gitlab-ci). I will merge it after the current jobs finish (I will ignore Travis to avoid further delays). |
This PR includes:
operator<<
for shooting problem, action model, and differential action model to enableprint(ddp.problem)
orprint(ddp.running_models[t])
which is useful in debugging to get information on the problemMeshcatVisualizer
when using the latest Pinocchio devel branch (not sure when it broke)