Cleanup validation checks #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efernandez
force-pushed
the
cleanup_validation_checks
branch
from
16e73a8
to
019c7cc
Compare
efernandez
commented
Feb 6, 2020
svwilliams
approved these changes
Feb 6, 2020
This allows to load a covariance matrix from the parameter server, provided in a list with the diagonal values.
This only tests the getCovarianceMatrixDiagonalParam helper function for now.
Only tests isSymmetric and isPSD.
efernandez
force-pushed
the
cleanup_validation_checks
branch
from
019c7cc
to
04efb6c
Compare
|
Rebased and updated with review feedback. |
svwilliams
approved these changes
Feb 6, 2020
ayrton04
approved these changes
Feb 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is on top of #137 and #138 because it changes code contributed in those.
This provides the following:
getCovarianceMatrixDiagonalParamhelper function, that allows to load a covariance matrix from the parameter server, provided in a list with the diagonal values.util.h. This only tests thegetCovarianceMatrixDiagonalParamhelper function for now.isSymmetricandisPSDhelper functionseigen.h. Only testsisSymmetricandisPSD.