Const deserialize #148
Merged
Const deserialize #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires the graph_loader_ to be mutable.
ayrton04
approved these changes
Feb 21, 2020
svwilliams
approved these changes
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the
fuse_core::GraphDeserializerandfuse_core::TransactionDeserializerdeserializemethodconst.In the particular case of the
fuse_core::GraphDeserializerI had to set thegraph_loader_mutablefor the reason explain in the code with aTODOcomment. I think this is better than not making the methodsconst, because otherwise any method from another class using this deserializer cannot beconst.