Patch Tukey loss for Ceres < 2.0.0 #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@svwilliams @ayrton04 for review |
efernandez
force-pushed
the
patch_tukey_loss_before_ceres_2
branch
from
6fd0758
to
0c5c495
Compare
efernandez
force-pushed
the
patch_tukey_loss_before_ceres_2
branch
from
0c5c495
to
c972cee
Compare
svwilliams
approved these changes
Mar 18, 2020
efernandez
commented
Mar 18, 2020
ayrton04
approved these changes
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ceres-solver-review.googlesource.com/c/ceres-solver/+/16700 has been merged (see ceres-solver/ceres-solver@6da3647), so now the
TukeyLosswon't need any workaround once Ceres 2.0.0 is release. You could also try building it from source and installing it in your system, as I've done.This PR adds a workaround for
TukeyLossif Ceres < 2.0.0, updates the comments and unit tests.