Target frame optional #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayrton04
approved these changes
Dec 10, 2020
svwilliams
approved these changes
Dec 10, 2020
|
This PR now needs a rebase. I really wish git would handle these squash-and-merge cases more gracefully. |
efernandez
force-pushed
the
target-frame-optional
branch
from
76a01b2
to
47687c8
Compare
|
That's ok. Indeed, in this case three 3-way merges got applied when I rebased it, so I guess that prevents github from running an automatic rebase/merge itself. At least in this case, my experience tells me that's better to review the result of the the rebase/3-way merge. That's what I've done and I believe things are fine. |
|
I've just sent a commit to remove the optional |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #216, this also makes the target frame parameters optional.
If not set, the target frame parameters default to
empty(). In that case not transformation is performed. In this implementation, I actually fallback to the messageheader.frame_id, because it looks cleaner, but we could also consider bigger changes to factorize things out.