Improve logs on graph update exception thrown #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efernandez
force-pushed
the
improve-logs-on-graph-update-exception-thrown
branch
from
1147afb
to
ec583bf
Compare
When the graph update method throws an exception the node crashes and there is no way to know what transaction caused the exception because we call notify after successfully updating the graph. This catches any exception thrown by the graph update method and logs a FATAL message that includes the current graph and the new transaction.
This homogenizes the exception messages from all exceptions thrown by the HashGraph class.
efernandez
force-pushed
the
improve-logs-on-graph-update-exception-thrown
branch
from
ec583bf
to
1ad0500
Compare
ayrton04
approved these changes
May 24, 2021
svwilliams
approved these changes
Jun 1, 2021
ayrton04
pushed a commit
that referenced
this pull request
Jul 11, 2021
* Catch graph update exceptions and log fatal msg When the graph update method throws an exception the node crashes and there is no way to know what transaction caused the exception because we call notify after successfully updating the graph. This catches any exception thrown by the graph update method and logs a FATAL message that includes the current graph and the new transaction. * Add full stop to exception messages This homogenizes the exception messages from all exceptions thrown by the HashGraph class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch graph update exceptions and log
FATALmessageWhen the graph
update()method throws an exception the node crashes andthere is no way to know what transaction caused the exception because we
call
notifyafter successfully updating the graph.This catches any exception thrown by the graph update method and logs a
FATALmessage that includes the current graph and the new transaction.Add full stop to exception messages
This homogenizes the exception messages from all exceptions thrown by
the
HashGraphclass.