Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment unused parameters #76

Merged

Conversation

efernandez
Copy link
Collaborator

Otherwise the compilation fails with: -Werror=unused-parameter
This happens with these flags: -Wall -Wextra

Otherwise the compilation fails with: -Werror=unused-parameter
This happens with these flags: -Wall -Wextra
Copy link
Contributor

@svwilliams svwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayrton04 Do you have any particular syntax for writing the would-be variable name? Or are you good with Transaction::ConstSharedPtr /*transaction*/?

@ayrton04
Copy link
Contributor

I don't feel strongly about it. I tend to just leave them as

void method(const Whatever&)

...but I'm indifferent.

@svwilliams svwilliams merged commit c93360d into locusrobotics:devel Jul 11, 2019
@efernandez efernandez deleted the comment_unused_parameters branch July 11, 2019 16:01
@efernandez
Copy link
Collaborator Author

The reason I commented the unused parameters instead of removing them was because the doxygen block references them, which I think it's a good reason against removing them, I guess. Either way, I also don't have a strong opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants