fix: edit load test missing the userclasses data by alterhu2020 · Pull Request #2171 · locustio/locust

alterhu2020 · 2022-08-23T13:26:17Z

fix the problem userclasses missing issue when edit the load test

cyberw · 2022-08-23T14:18:07Z

Does that work though? If you change the selected Users, that wont affect the ones that are already running, right?

alterhu2020 · 2022-08-23T14:36:48Z

Does that work though? If you change the selected Users, that wont affect the ones that are already running, right?

Yes,I had tested from my machine, It works as expected. It only reused the selected Users we had picked previously.

cyberw · 2022-08-23T16:10:46Z

Nice! Can you add a unit test that validates it?

Here’s some inspiration:

locust/locust/test/test_web.py

Line 410 in 4989f2a

def test_swarm_shape_class_specified(self):

mikenester · 2022-08-24T12:35:54Z


                else:
-                    user_classes = self.environment.available_user_classes
+                    user_classes = {key: value for (key, value) in self.environment.available_user_classes.items if


I tried out this change and got

File "/Users/michaelnester/git/locust/locust/web.py", line 167, in swarm user_classes = { TypeError: 'builtin_function_or_method' object is not iterable

I think it needs to be self.environment.available_user_classes.items(), which worked for me (using python 3.9)

yes, sorry. My fault typo error. python 3.10 works well from myside, but I think it's better to take use the code you corrected here.

mikenester · 2022-08-24T12:45:29Z

This change breaks test_swarm_defaults_to_all_available_userclasses_when_userclass_picker_is_active_and_no_userclass_in_payload.

The workflow is:

Run Locust w/ class picker and multiple user classes to choose from
Select one user class
- More specifically: select up to N - 1 user classes where N is the total number of available user classes
Run the test
Stop the test and start a new test, but don't select any user classes
- This defaults to all available user classes

Only the user class from the first run will be used

mikenester · 2022-08-24T13:13:02Z

@alterhu2020 I think i got a fix for this: master...mikenester:locust:fix-class-picker-bug-edit-running-test

… if test is already running

alterhu2020 · 2022-08-24T14:15:50Z

@alterhu2020 I think i got a fix for this: master...mikenester:locust:fix-class-picker-bug-edit-running-test

Yes, the code is better than mine, please go ahead merged it. thanks

mikenester · 2022-08-24T14:25:12Z

@alterhu2020 If you merge this alterhu2020#1, it should automatically update this PR and run the tests

alterhu2020 · 2022-08-24T14:26:10Z

BTW， @mikenester
When I run the locust unit test code or run the main.py or _main_.py from pycharm directly, it often returns following error:


Error
Traceback (most recent call last):
  File "C:\Users\Administrator\.conda\envs\locust\lib\unittest\loader.py", line 34, in testFailure
    raise self._exception
ImportError: Failed to import test module: locust
Traceback (most recent call last):
  File "C:\Users\Administrator\.conda\envs\locust\lib\unittest\loader.py", line 154, in loadTestsFromName
    module = __import__(module_name)
  File "D:\locust\locust\__init__.py", line 18, in <module>
    from .contrib.fasthttp import FastHttpUser
  File "D:\locust\locust\contrib\fasthttp.py", line 24, in <module>
    from locust.env import Environment
  File "D:\locust\locust\env.py", line 18, in <module>
    from .web import WebUI
  File "D:\locust\locust\web.py", line 6, in <module>
    from html import escape
  File "D:\locust\locust\html.py", line 6, in <module>
    from .stats import sort_stats
ImportError: attempted relative import with no known parent package

I know it related that we use the relative import path, but I don't know how to bypass it? Have we any guideline that can help people quick to setup the develop contribution environment? thanks

…ng-test Added check to swarm for class picker. Uses pre selected user classes if test is already running

alterhu2020 · 2022-08-24T14:28:45Z

@alterhu2020 If you merge this alterhu2020#1, it should automatically update this PR and run the tests

LGTM, Done as well

cyberw · 2022-08-24T14:41:04Z

Nice! But the test doesnt actually validate that the Users changed, does it?

mikenester · 2022-08-24T14:51:31Z

Nice! But the test doesnt actually validate that the Users changed, does it?

Perhaps I misunderstood, but I thought we don't want the users to change. So an example of the expected workflow should be:

Run locust with --class-picker and available user classes: UserClass1, UserClass2, UserClass3
Run a test with just UserClass1
Edit the running test. User Class Count & Spawn Rate values can be arbitrary
Validate that only UserClass1 is active
- The reported bug being that instead, UserClass1, UserClass2 & UserClass3 were all active
- Validated on line 440 of locust/test/test_web.py in this PR

alterhu2020 · 2022-08-24T14:56:25Z

Nice! But the test doesnt actually validate that the Users changed, does it?

Perhaps I misunderstood, but I thought we don't want the users to change. So an example of the expected workflow should be:

Run locust with --class-picker and available user classes: UserClass1, UserClass2, UserClass3

Run a test with just UserClass1

Edit the running test. User Class Count & Spawn Rate values can be arbitrary

Validate that only UserClass1 is active

The reported bug being that instead, UserClass1, UserClass2 & UserClass3 were all active

Validated on line 440 of locust/test/test_web.py in this PR

Yes. I think @mikenester is right. @cyberw for the Users Changed scenario I think It related to another feature I raised in issue: #2169, right? If we can support that I think it's a great improvement.
Thanks Team.

mikenester · 2022-08-24T14:57:17Z

BTW， @mikenester When I run the locust unit test code or run the main.py or _main_.py from pycharm directly, it often returns following error:


Error
Traceback (most recent call last):
  File "C:\Users\Administrator\.conda\envs\locust\lib\unittest\loader.py", line 34, in testFailure
    raise self._exception
ImportError: Failed to import test module: locust
Traceback (most recent call last):
  File "C:\Users\Administrator\.conda\envs\locust\lib\unittest\loader.py", line 154, in loadTestsFromName
    module = __import__(module_name)
  File "D:\locust\locust\__init__.py", line 18, in <module>
    from .contrib.fasthttp import FastHttpUser
  File "D:\locust\locust\contrib\fasthttp.py", line 24, in <module>
    from locust.env import Environment
  File "D:\locust\locust\env.py", line 18, in <module>
    from .web import WebUI
  File "D:\locust\locust\web.py", line 6, in <module>
    from html import escape
  File "D:\locust\locust\html.py", line 6, in <module>
    from .stats import sort_stats
ImportError: attempted relative import with no known parent package

I know it related that we use the relative import path, but I don't know how to bypass it? Have we any guideline that can help people quick to setup the develop contribution environment? thanks

Not sure if I can help with this one. I don't think you'll be able to successfully run individual files, since relative import in python can get broken in that scenario.

In terms of testing, I personally modify tox.ini in the following way. Change line 30 from

python3 -m coverage run -m unittest discover []

to the intended unittest path:

python3 -m coverage run -m unittest locust.tests.test_web.TestWebUI.test_exceptions_csv

Then you can run:

tox -e py37 if you're using python 3.7
tox -e py38 if you're using python 3.8
tox -e py39 if you're using python 3.9
tox -e py310 if you're using python 3.10

alterhu2020 · 2022-08-24T15:08:09Z

BTW， @mikenester When I run the locust unit test code or run the main.py or _main_.py from pycharm directly, it often returns following error:
Error
Traceback (most recent call last):
  File "C:\Users\Administrator\.conda\envs\locust\lib\unittest\loader.py", line 34, in testFailure
    raise self._exception
ImportError: Failed to import test module: locust
Traceback (most recent call last):
  File "C:\Users\Administrator\.conda\envs\locust\lib\unittest\loader.py", line 154, in loadTestsFromName
    module = __import__(module_name)
  File "D:\locust\locust\__init__.py", line 18, in <module>
    from .contrib.fasthttp import FastHttpUser
  File "D:\locust\locust\contrib\fasthttp.py", line 24, in <module>
    from locust.env import Environment
  File "D:\locust\locust\env.py", line 18, in <module>
    from .web import WebUI
  File "D:\locust\locust\web.py", line 6, in <module>
    from html import escape
  File "D:\locust\locust\html.py", line 6, in <module>
    from .stats import sort_stats
ImportError: attempted relative import with no known parent package
I know it related that we use the relative import path, but I don't know how to bypass it? Have we any guideline that can help people quick to setup the develop contribution environment? thanks
Not sure if I can help with this one. I don't think you'll be able to successfully run individual files, since relative import in python can get broken in that scenario.

In terms of testing, I personally modify tox.ini in the following way. Change line 30 from

python3 -m coverage run -m unittest discover []

to the intended unittest path:

python3 -m coverage run -m unittest locust.tests.test_web.TestWebUI.test_exceptions_csv

Then you can run:

tox -e py37 if you're using python 3.7

tox -e py38 if you're using python 3.8

tox -e py39 if you're using python 3.9

tox -e py310 if you're using python 3.10

Thanks the tips, but how we can active the debugger, I want to read the code step by step...

cyberw · 2022-08-25T06:58:40Z

Perhaps I misunderstood, but I thought we don't want the users to change

I misunderstood what you were trying to do, sorry :)

This looks good to me now. Should I merge?

mikenester · 2022-08-25T12:05:46Z

This looks good to me now. Should I merge?

Yeah, I think it's good to go 👍

cyberw · 2022-08-25T13:52:59Z

thanks!

fix: edit load test missing the userclasses data

dc662d0

alterhu2020 mentioned this pull request Aug 23, 2022

WebUI Edit running load test not carried user_classes when enabled --class-picker #2170

Closed

mikenester reviewed Aug 24, 2022

View reviewed changes

mikenester added 2 commits August 24, 2022 09:28

Added check to swarm for class picker. Uses pre selected user classes…

90967f9

… if test is already running

Merge branch 'master' into fix-class-picker-bug-edit-running-test

750ad90

Merge pull request #1 from mikenester/fix-class-picker-bug-edit-runni…

389667b

…ng-test Added check to swarm for class picker. Uses pre selected user classes if test is already running

cyberw merged commit e42f649 into locustio:master Aug 25, 2022

Conversation

alterhu2020 commented Aug 23, 2022

Uh oh!

cyberw commented Aug 23, 2022

Uh oh!

alterhu2020 commented Aug 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cyberw commented Aug 23, 2022

Uh oh!

mikenester Aug 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alterhu2020 Aug 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mikenester commented Aug 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mikenester commented Aug 24, 2022

Uh oh!

alterhu2020 commented Aug 24, 2022

Uh oh!

mikenester commented Aug 24, 2022

Uh oh!

alterhu2020 commented Aug 24, 2022

Uh oh!

alterhu2020 commented Aug 24, 2022

Uh oh!

cyberw commented Aug 24, 2022

Uh oh!

mikenester commented Aug 24, 2022

Uh oh!

alterhu2020 commented Aug 24, 2022

Uh oh!

mikenester commented Aug 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alterhu2020 commented Aug 24, 2022

Uh oh!

cyberw commented Aug 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mikenester commented Aug 25, 2022

Uh oh!

cyberw commented Aug 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

alterhu2020 commented Aug 23, 2022 •

edited

Loading

mikenester Aug 24, 2022 •

edited

Loading

alterhu2020 Aug 24, 2022 •

edited

Loading

mikenester commented Aug 24, 2022 •

edited

Loading

mikenester commented Aug 24, 2022 •

edited

Loading

cyberw commented Aug 25, 2022 •

edited

Loading