Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more clear wording in --run-time reached stopping log message. #2172

Merged
merged 1 commit into from
Aug 25, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions locust/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ def stop_and_optionally_quit():
else:
logger.info("--autoquit not specified, leaving web ui running indefinitely")
else: # --headless run
logger.info("--run-time limit reached. Stopping Locust")
logger.info("--run-time limit reached, shutting down")
runner.quit()

def spawn_run_time_quit_greenlet():
Expand All @@ -325,7 +325,7 @@ def start_automatic_run():
start_time = time.monotonic()
while len(runner.clients.ready) < options.expect_workers:
if options.expect_workers_max_wait and options.expect_workers_max_wait < time.monotonic() - start_time:
logger.error("Gave up waiting for workers to connect.")
logger.error("Gave up waiting for workers to connect")
runner.quit()
sys.exit(1)
logging.info(
Expand Down
4 changes: 2 additions & 2 deletions locust/test/test_log.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def my_task(self):
output,
)
self.assertIn(
f"{socket.gethostname()}/INFO/locust.main: --run-time limit reached. Stopping Locust",
f"{socket.gethostname()}/INFO/locust.main: --run-time limit reached, shutting down",
output,
)
self.assertIn(
Expand Down Expand Up @@ -192,7 +192,7 @@ def my_task(self):
log_content,
)
self.assertIn(
f"{socket.gethostname()}/INFO/locust.main: --run-time limit reached. Stopping Locust",
f"{socket.gethostname()}/INFO/locust.main: --run-time limit reached, shutting down",
log_content,
)
self.assertIn(
Expand Down