Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web UI style fixes: about dialog cannot be opened in the startup page #2173

Merged
merged 3 commits into from
Aug 27, 2022

Conversation

alterhu2020
Copy link
Contributor

@alterhu2020 alterhu2020 commented Aug 27, 2022

Fix these issues:

  • When you startup the locust web page first time, in the main page, we cannot open the about page when click the bottom link "About"
  • In the "Start new load test" and "Edit running load test" page, the top left close button is not formatted correct(disorderred) , so I corrected the close link position to the same as in the "About" dialog page. see the following screenshot:
  1. Modified screenshot, which can show the "About" dialog in the startup page:
    image

  2. The "close" button in the "Start new load test" dialog page:
    image

  3. The "close" button in the "Edit running load test" dialog page:
    image

@cyberw
Copy link
Collaborator

cyberw commented Aug 27, 2022

Good stuff, thanks!

@cyberw cyberw merged commit ff7b7b2 into locustio:master Aug 27, 2022
@cyberw cyberw changed the title fix(style): about dialog cannot be opened in the startup page Web UI style fixes: about dialog cannot be opened in the startup page Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants