Bugfix/2614 relative assets and stats links #2615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You accidentally reverted logo.png I think :) @andrewbaldwin44 Does this look good to you, apart from that? It looks good to me... |
|
Looks great to me, thanks for fixing this! I'm not sure what's changed or why Vite is trying to overwrite the logo in build now, I need to check this. Maybe for the moment we can just reset it with |
|
Thanks guys, this is my first ever real open source PR, I was a bit nervous about it 😅 Logo has been reset! |
|
Looks good to me now! @cyberw good to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2614 by making all /assets and /stats webui links relative.