Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont throw an exception in FastHttpUser if a request is made with stream=True and the connection fails #2642

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Dont throw an exception in FastHttpUser if a request is made with stream=True and the connection fails #2642

merged 1 commit into from
Mar 18, 2024

Conversation

cyberw
Copy link
Collaborator

@cyberw cyberw commented Mar 18, 2024

Fixes #2640

@cyberw cyberw merged commit 76575c9 into master Mar 18, 2024
23 checks passed
@neiser neiser mentioned this pull request Mar 18, 2024
Merged
@neiser
Copy link
Contributor

neiser commented Mar 18, 2024

@cyberw Thanks for that super quick fix. I was just about to open a PR also addressing this. Your code change does look more sound, though. I've another fix which I've already validated locally, see #2643

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'NoneType' object has no attribute 'get' when stream=True in FastHttpSession.request
2 participants
@cyberw @neiser