Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Import wiki to docs #2734

Merged
merged 14 commits into from
Jun 7, 2024
Merged

Docs: Import wiki to docs #2734

merged 14 commits into from
Jun 7, 2024

Conversation

plaindocs
Copy link
Collaborator

@plaindocs plaindocs commented May 26, 2024

  • added imports to TOC
  • deleted Home.rst
  • removed spurious html formatting li, h4 etc
  • fixed H1s
  • rename/move files
  • actually look at content :-p
  • migrated links to current content
  • moved articles to discussion forum
  • promoted "Increase my request rate/RPS"
  • integrated installation troubleshooting

Not done

  • automation of examples
  • Move "clear cookies" FAQ

- added imports to TOC
- deleted Home.rst
- removed spurious html formatting `li`, `h4` etc
- fixed H1s

Still to do

- rename files
- actually look at content :-p
@cyberw
Copy link
Collaborator

cyberw commented May 27, 2024

A good start, but needs some work.

Increase my request rate/RPS is great and really deserves a top level entry (with a link to the discussion forum for followup-questions).

Same with installation issues (but it needs to be merged nicely with the current installation page somehow)

Articles need to be checked that they still exist (remove the oldest ones) and added as an entry in the discussion forum. It can still be a page in the docs, but maybe just a few titles and a link to that entry. I prefer not having to maintain the list myself.

Clear cookies, to make the next task iteration seem like a new user to my system under test can be moved somewhere, maybe to a separate file under examples/. And btw, the examples are linked from here https://docs.locust.io/en/stable/writing-a-locustfile.html#examples but it woud be really nice if we could autogenerate a list based on all the files!

@plaindocs plaindocs marked this pull request as ready for review June 6, 2024 10:23
@plaindocs
Copy link
Collaborator Author

@cyberw this is probably at the good enough stage, what do you think?

@cyberw
Copy link
Collaborator

cyberw commented Jun 6, 2024

A few things:

  1. Installation issues needs a proper introduction, probably even its own page, linked here

Install the package (check the wiki if the installation fails)

And some of the titles (the ones that are error messages) should be formatted as code, and not as headers. It looks a bit weird atm:

image
  1. There is some broken formatting here. And the last part about "Launch locust -f scripts/locustfile.py..." doesnt fit there, where did that come from?
image

@cyberw
Copy link
Collaborator

cyberw commented Jun 6, 2024

There's an extra "the" here:

If you need some help digging into server side problems, or you’re having trouble generating enough load to saturate your system, take a look at the Increasing the request rate.

Probably turning the sentence around to start with "having trouble generating enough load" fits better with the title of the page, but perhaps the title could be reworked as well?

@cyberw
Copy link
Collaborator

cyberw commented Jun 6, 2024

Formatting:

image

@cyberw
Copy link
Collaborator

cyberw commented Jun 6, 2024

This screenshot is too small (maybe it has always been this way)

image

@cyberw
Copy link
Collaborator

cyberw commented Jun 6, 2024

Random line breaks in the titles imported from the wiki:

image

@cyberw
Copy link
Collaborator

cyberw commented Jun 6, 2024

Other than that, great stuff!

@plaindocs
Copy link
Collaborator Author

I should have said, I'm trying to do the minimum viable import so we can merge this, so I'm concentrating more on importing the wiki as is rather than making sure all of the imported docs are in tip top shape, then we can iterate over it as part of the overhaul.

The code/title heading is in that psutil thing is gonna look weird either way unless we reword it.
The locust -f scripts/locustfile.py is also as in the wiki. I've refactored that section (but what should the last code line read)

  • Fixed the random line breaks
  • Fixed 'the the'
  • Fixed code formatting
  • Fixed image width

@cyberw
Copy link
Collaborator

cyberw commented Jun 7, 2024

I should have said, I'm trying to do the minimum viable import so we can merge this, so I'm concentrating more on importing the wiki as is rather than making sure all of the imported docs are in tip top shape, then we can iterate over it as part of the overhaul.

Gotcha!

The code/title heading is in that psutil thing is gonna look weird either way unless we reword it.
The locust -f scripts/locustfile.py is also as in the wiki. I've refactored that section (but what should the last code line read)

The "deploy on local environment" part of Installation in the wiki is confusing and broken. Just nuke it.

Still a few broken line endings from the import (but you can fix it later if you want)

image

@cyberw
Copy link
Collaborator

cyberw commented Jun 7, 2024

oh, and formatting the "FAQ" page is not top prio (if it should even exist at all, I'd prefer moving the entries there to other places). What does need to be fixed is the explicit reference to the wiki :) (you can just remove this paragraph)

If you have questions about Locust that are not answered here, please check StackOverflow, or post your question there. This wiki is not for asking questions but for answering them :)

@plaindocs
Copy link
Collaborator Author

Agreed - migrating FAQ to other places usually makes more sense. But to do that properly I've have to take a proper look at the contents. :-D

@cyberw cyberw changed the title Import wiki to docs Docs: Import wiki to docs Jun 7, 2024
@cyberw
Copy link
Collaborator

cyberw commented Jun 7, 2024

Looks good now! I'll squash the commits, unless you want a plain merge?

@plaindocs
Copy link
Collaborator Author

plaindocs commented Jun 7, 2024 via email

@cyberw cyberw merged commit 8f04a6b into locustio:master Jun 7, 2024
14 checks passed
@cyberw
Copy link
Collaborator

cyberw commented Jun 7, 2024

Btw, there's an open PR for changing the build/install process (#2725) so don't for some reason go off spending time documenting the current install procedure :)

@plaindocs plaindocs deleted the sam-wiki-import branch June 7, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants