Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a slaves-tab to show the id, status and number of users running on each slave. #305

Merged
merged 3 commits into from
Oct 27, 2017

Conversation

TZer0
Copy link
Contributor

@TZer0 TZer0 commented Jul 13, 2015

The tab is only visible when running in master mode. The slave-counter uses the same data (slave_count is no longer passed).
screenshot from 2015-07-13 12 15 56
(The white blocks are just hiding my hostnames)

Due to the fact that the tests refuse to run on my machine, I am forced to have the centralized build system run them.

@TZer0
Copy link
Contributor Author

TZer0 commented Jul 13, 2015

And the tests pass.

Is this good to go?

@TZer0
Copy link
Contributor Author

TZer0 commented Jul 28, 2015

Didn't realise that github will actively track my master branch. I've moved some commits out of master to fix the issue.

@mbeacom
Copy link
Member

mbeacom commented Sep 8, 2017

@TZer0 Are you still interested in having this merged?

@TZer0
Copy link
Contributor Author

TZer0 commented Sep 8, 2017

@mbeacom I don't use Locust anymore, but sure - why not? It may save someone else from some serious trouble.

@mbeacom
Copy link
Member

mbeacom commented Sep 8, 2017

@TZer0 Great! Thank you for the contribution! Would you mind rebasing the branch?

@TZer0
Copy link
Contributor Author

TZer0 commented Sep 8, 2017

@mbeacom I'll fix it after work in ~9 hours.

@TZer0
Copy link
Contributor Author

TZer0 commented Sep 8, 2017

@mbeacom Should be it. I'll check up on it if the tests do not pass.

@TZer0
Copy link
Contributor Author

TZer0 commented Oct 17, 2017

Does anyone have time to merge this?

@mbeacom
Copy link
Member

mbeacom commented Oct 17, 2017

@TZer0 I'm going to test this in a few. If everything look's good, I'll merge it in!

@mbeacom mbeacom added LGTM and removed needs review labels Oct 27, 2017
Copy link
Member

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this and seems to be working appropriately in distributed mode! LGTM :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants