Fix bytes/text confusion with response objects #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
response.content is a byte string. It should be compared against other byte strings. To examine the response content as text, use the response.text attribute. Fixes warnings when Python is passed the -b argument (Issue warnings about str(bytes_instance), str(bytearray_instance) and comparing bytes/bytearray with str.) BytesWarning: str() on a bytes instance For additional information on the -b argument, see: https://docs.python.org/3/using/cmdline.html#cmdoption-b For additional information on response.text, see: http://docs.python-requests.org/en/master/api/#requests.Response.text
Codecov Report
@@ Coverage Diff @@
## master #762 +/- ##
=======================================
Coverage 65.13% 65.13%
=======================================
Files 14 14
Lines 1417 1417
Branches 222 222
=======================================
Hits 923 923
Misses 443 443
Partials 51 51
Continue to review full report at Codecov.
|
cgoldberg
approved these changes
Mar 26, 2018
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
response.contentis a byte string. It should be compared against other byte strings. To examine the response content as text, use theresponse.textattribute.Fixes warnings when Python is passed the
-bargument (Issue warnings aboutstr(bytes_instance),str(bytearray_instance)and comparing bytes/bytearray with str.)For additional information on the
-bargument, see:https://docs.python.org/3/using/cmdline.html#cmdoption-b
For additional information on response.text, see:
http://docs.python-requests.org/en/master/api/#requests.Response.text