Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix access method #14

Closed
wants to merge 1 commit into from
Closed

Fix access method #14

wants to merge 1 commit into from

Conversation

Pierozi
Copy link
Contributor

@Pierozi Pierozi commented Jun 17, 2015

the Error class use public call on method Base::convert_object_to_array()

@Pierozi
Fix access method
0489779 
the Error class use public call on method `Base::convert_object_to_array()`
@lode lode mentioned this pull request Jun 17, 2015
Merged
@lode
Copy link
Owner

lode commented Jun 17, 2015

I rather not make this method public as should only be used internally.
I've fixed it in #15 by letter the error object extend the base class anyway. This is just released as v1.1.1.

Thanks for the report!

@lode lode closed this Jun 17, 2015
@Pierozi
Copy link
Contributor Author

Pierozi commented Jun 18, 2015

Ok great, thanks you for this lib, lightest and helpful.

@lode
Copy link
Owner

lode commented Jun 18, 2015

You're welcome, great to hear it is useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug duplicate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pierozi @lode