Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enable limitRange / resourceQuota in duo #2061

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

FabianKramm
Copy link
Member

What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves ENG-3646

Copy link

netlify bot commented Aug 14, 2024

Deploy Preview for vcluster-docs canceled.

Name Link
🔨 Latest commit f8dfcc8
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/66bc73b380558c0008a8932c

Copy link
Contributor

@hidalgopl hidalgopl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I'd add two test cases for limitRange.enabled: false & resourceQuota.enabled: false to have all combinations covered

@FabianKramm FabianKramm merged commit fb5034c into loft-sh:main Aug 14, 2024
61 checks passed
@loft-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
v0.20

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

FabianKramm added a commit that referenced this pull request Aug 14, 2024
[v0.20] Merge pull request #2061 from FabianKramm/main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-v0.20 backport this PR to v0.20 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants